lkml.org 
[lkml]   [2019]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition
From
Date
On 13/06/2019 11:10, Marc Gonzalez wrote:

> Here are my observations for a 8998 board:
>
> 1) If I apply only the readl_poll_timeout() fix (not the mask_pcs_ready fixup)
> qcom_pcie_probe() fails with a timeout in phy_init.
> => this is in line with your regression analysis.
>
> 2) Your patch also fixes a long-standing bug in UFS init whereby sending
> lots of information to the console during phy init would lead to an
> incorrectly diagnosed time-out.
>
> Good stuff!
>
> Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> Tested-by: Marc Gonzalez <marc.w.gonzalez@free.fr>

Hello Kishon,

Could you take this patch through your tree?
It fixes a pair of nasty bugs.

I do have a follow-up (trivial) patch on top of this one:
https://lore.kernel.org/patchwork/patch/1088044/

What are your thoughts on the usleep_range issue?
https://lore.kernel.org/patchwork/patch/1088035/

Regards.

\
 
 \ /
  Last update: 2019-06-19 14:44    [W:0.074 / U:3.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site