[lkml]   [2019]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 2/2] DRM: Add KMS driver for the Ingenic JZ47xx SoCs
Hi Paul.

On Mon, Jun 03, 2019 at 05:23:31PM +0200, Paul Cercueil wrote:
> Add a KMS driver for the Ingenic JZ47xx family of SoCs.
> This driver is meant to replace the aging jz4740-fb driver.
> This driver does not make use of the simple pipe helper, for the reason
> that it will soon be updated to support more advanced features like
> multiple planes, IPU integration for colorspace conversion and up/down
> scaling, support for DSI displays, and TV-out and HDMI outputs.
> Signed-off-by: Paul Cercueil <>
> Tested-by: Artur Rojek <>
> ---
> Notes:
> v2: - Remove custom handling of panel. The panel is now discovered using
> the standard API.
> - Lots of small tweaks suggested by upstream
> v3: - Use devm_drm_dev_init()
> - Update compatible strings to -lcd instead of -drm
> - Add destroy() callbacks to plane and crtc
> - The ingenic,lcd-mode is now read from the bridge's DT node
> v4: Remove ingenic,lcd-mode property completely. The various modes are now
> deduced from the connector type, the pixel format or the bus flags.
> v5: - Fix framebuffer size incorrectly calculated for 24bpp framebuffers
> - Use 32bpp framebuffer instead of 16bpp, as it'll work with both
> 16-bit and 24-bit panel
> - Get rid of drm_format_plane_cpp() which has been dropped upstream
> - Avoid using drm_format_info->depth, which is deprecated.
In the drm world we include the revision notes in the changelog.
So I did this when I applied it to drm-misc-next.

Fixed a few trivial checkpatch warnings about indent too.
There was a few too-long-lines warnings that I ignored. Fixing them
would have hurt readability.

I assume you will maintain this driver onwards from now.
Please request drm-misc commit rights (see
You will need a legacy SSH account.

And you should familiarize yourself with the maintainer-tools:

For my use I use "dim update-branches; dim apply; dim push
So only a small subset i needed for simple use.


 \ /
  Last update: 2019-06-19 14:27    [W:0.062 / U:1.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site