lkml.org 
[lkml]   [2019]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call
From
Date
On 19/06/2019 06:13, Martin Blumenstingl wrote:
> Hi Colin,
>
>> Currently the call to device_property_read_u32_array is not error checked
>> leading to potential garbage values in the delays array that are then used
>> in msleep delays. Add a sanity check to the property fetching.
>>
>> Addresses-Coverity: ("Uninitialized scalar variable")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> I have also sent a patch [0] to fix initialize the array.
> can you please look at my patch so we can work out which one to use?
>
> my concern is that the "snps,reset-delays-us" property is optional,
> the current dt-bindings documentation states that it's a required
> property. in reality it isn't, there are boards (two examples are
> mentioned in my patch: [0]) without it.
>
> so I believe that the resulting behavior has to be:
> 1. don't delay if this property is missing (instead of delaying for
> <garbage value> ms)
> 2. don't error out if this property is missing
>
> your patch covers #1, can you please check whether #2 is also covered?
> I tested case #2 when submitting my patch and it worked fine (even
> though I could not reproduce the garbage values which are being read
> on some boards)
>
>
> Thank you!
> Martin
>
>
> [0] https://lkml.org/lkml/2019/4/19/638
>
Is that the correct link?

Colin

\
 
 \ /
  Last update: 2019-06-19 08:56    [W:0.046 / U:2.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site