lkml.org 
[lkml]   [2019]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe
On Wed, Jun 19, 2019 at 08:36:07AM +0200, Simon Sandström wrote:
> We can get rid of a few iounmaps in the middle of the function by
> re-ordering the error handling labels and adding two new labels.
>
> Signed-off-by: Simon Sandström <simon@nikanor.nu>
> ---
>
> This change has not been tested besides by compiling. It might be good
> took take an extra look to make sure that I got everything right.
>

You have the right instincts that when something looks really
complicated that's probably for a reason. That attitude will serve you
well in the future! But in this case it's staging code so the original
code is just strange.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

> Also, this change was proposed by Dan Carpenter. Should I add anything
> in the commit message to show this?

There is a Suggested-by: tag for this, but don't resend because I don't
care and I've already reviewed this version so I don't want to review
the patch again.

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-06-19 08:54    [W:0.050 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site