lkml.org 
[lkml]   [2019]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 1/2] hinic: add rss support
On Tue, 11 Jun 2019 18:12:33 +0000, Xue Chaojing wrote:
> + for (i = 0; i < HINIC_RSS_INDIR_SIZE; i++)
> + indir_tbl[i] = (i / HINIC_RSS_INDIR_SIZE) * nic_dev->num_rss +
> + i % nic_dev->num_rss;

This looks suspicious:

i is in range [0, HINIC_RSS_INDIR_SIZE)
so i / HINIC_RSS_INDIR_SIZE is always 0

For the rest please use ethtool_rxfh_indir_default()

\
 
 \ /
  Last update: 2019-06-13 19:10    [W:0.045 / U:13.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site