lkml.org 
[lkml]   [2019]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mei: no need to check return value of debugfs_create functions
On Tue, Jun 11, 2019 at 08:33:57PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Tomas Winkler <tomas.winkler@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/misc/genwqe/card_base.c | 5 -
> drivers/misc/genwqe/card_base.h | 2 +-
> drivers/misc/genwqe/card_debugfs.c | 165 +++++----------------------
> drivers/misc/genwqe/card_dev.c | 6 +-
> drivers/misc/mei/debugfs.c | 47 ++------
> drivers/misc/mei/main.c | 8 +-
> drivers/misc/mei/mei_dev.h | 7 +-
> drivers/misc/mic/card/mic_debugfs.c | 18 +--
> drivers/misc/mic/cosm/cosm_debugfs.c | 4 -
> drivers/misc/mic/host/mic_debugfs.c | 4 -
> drivers/misc/mic/scif/scif_debugfs.c | 5 -
> drivers/misc/mic/vop/vop_debugfs.c | 4 -
> drivers/misc/ti-st/st_kim.c | 4 -
> drivers/misc/vmw_balloon.c | 19 +--
> 14 files changed, 51 insertions(+), 247 deletions(-)

Ugh, nope, wrong patch, need to break this one up, sorry...

greg k-h

\
 
 \ /
  Last update: 2019-06-11 20:38    [W:0.081 / U:2.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site