lkml.org 
[lkml]   [2019]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] firmware: ti_sci: Always request response from firmware
From
Date
On 28/05/2019 18:55, Andrew F. Davis wrote:
> TI-SCI firmware will only respond to messages when the
> TI_SCI_FLAG_REQ_ACK_ON_PROCESSED flag is set. Most messages already do
> this, set this for the ones that do not.
>
> This will be enforced in future firmware that better match the TI-SCI
> specifications, this patch will not break users of existing firmware.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Acked-by: Nishanth Menon <nm@ti.com>
> Tested-by: Alejandro Hernandez <ajhernandez@ti.com>
> ---
>
> Changes from v1:
> - Rebased on v5.2-rc2

Thanks, queuing up for 5.3.

-Tero

>
> drivers/firmware/ti_sci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index ef93406ace1b..36ce11a67235 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -466,9 +466,9 @@ static int ti_sci_cmd_get_revision(struct ti_sci_info *info)
> struct ti_sci_xfer *xfer;
> int ret;
>
> - /* No need to setup flags since it is expected to respond */
> xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_VERSION,
> - 0x0, sizeof(struct ti_sci_msg_hdr),
> + TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> + sizeof(struct ti_sci_msg_hdr),
> sizeof(*rev_info));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> @@ -596,9 +596,9 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
> info = handle_to_ti_sci_info(handle);
> dev = info->dev;
>
> - /* Response is expected, so need of any flags */
> xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_DEVICE_STATE,
> - 0, sizeof(*req), sizeof(*resp));
> + TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> + sizeof(*req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> dev_err(dev, "Message alloc failed(%d)\n", ret);
>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

\
 
 \ /
  Last update: 2019-06-11 19:32    [W:0.052 / U:7.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site