lkml.org 
[lkml]   [2019]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] perf script/intel-pt: set synth_opts.callchain for use_browser > 0
Em Tue, Jun 11, 2019 at 07:18:09AM +0000, Song Liu escreveu:
>
>
> > On Jun 10, 2019, at 11:45 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> > On 11/06/19 2:42 AM, Song Liu wrote:
> >> +++ b/tools/perf/util/intel-pt.c
> >> @@ -2588,7 +2588,7 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
> >> } else {
> >> itrace_synth_opts__set_default(&pt->synth_opts,
> >> session->itrace_synth_opts->default_no_sample);
> >> - if (use_browser != -1) {
> >> + if (use_browser > 0) {

> > That code has changed recently. Refer:

> > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=26f19c2eb7e54

> Thanks for a better fix! I was using Arnaldo's perf/urgent branch, and missed
> this one.

Your report shows this one should move to perf/urgent, will try to do
that after processing a large perf/core batch...

- Arnaldo
\
 
 \ /
  Last update: 2019-06-11 17:47    [W:0.050 / U:3.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site