lkml.org 
[lkml]   [2019]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/3] pinctrl: freescale: Add i.MX8MN pinctrl driver support
Date
> From: Anson.Huang@nxp.com [mailto:Anson.Huang@nxp.com]
> Sent: Thursday, May 30, 2019 11:06 AM
>
> From: Anson Huang <Anson.Huang@nxp.com>
>
> Add the pinctrl driver support for i.MX8MN.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/pinctrl/freescale/Kconfig | 7 +
> drivers/pinctrl/freescale/Makefile | 1 +
> drivers/pinctrl/freescale/pinctrl-imx8mn.c | 348
> +++++++++++++++++++++++++++++
> 3 files changed, 356 insertions(+)
> create mode 100644 drivers/pinctrl/freescale/pinctrl-imx8mn.c
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index aeab0d9..4ff52fa 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -123,6 +123,13 @@ config PINCTRL_IMX7ULP
> help
> Say Y here to enable the imx7ulp pinctrl driver
>
> +config PINCTRL_IMX8MN

Nitpick: this seems should be under imx8mm if in alphabetical order

> + bool "IMX8MN pinctrl driver"
> + depends on ARCH_MXC && ARM64
> + select PINCTRL_IMX
> + help
> + Say Y here to enable the imx8mn pinctrl driver
> +
> config PINCTRL_IMX8MM
> bool "IMX8MM pinctrl driver"
> depends on ARCH_MXC && ARM64
> diff --git a/drivers/pinctrl/freescale/Makefile
> b/drivers/pinctrl/freescale/Makefile
> index 02020a7..18225da 100644
> --- a/drivers/pinctrl/freescale/Makefile
> +++ b/drivers/pinctrl/freescale/Makefile
> @@ -18,6 +18,7 @@ obj-$(CONFIG_PINCTRL_IMX6SX) += pinctrl-imx6sx.o
> obj-$(CONFIG_PINCTRL_IMX6UL) += pinctrl-imx6ul.o
> obj-$(CONFIG_PINCTRL_IMX7D) += pinctrl-imx7d.o
> obj-$(CONFIG_PINCTRL_IMX7ULP) += pinctrl-imx7ulp.o
> +obj-$(CONFIG_PINCTRL_IMX8MN) += pinctrl-imx8mn.o

ditto

> obj-$(CONFIG_PINCTRL_IMX8MM) += pinctrl-imx8mm.o
> obj-$(CONFIG_PINCTRL_IMX8MQ) += pinctrl-imx8mq.o
> obj-$(CONFIG_PINCTRL_IMX8QM) += pinctrl-imx8qm.o
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> new file mode 100644
> index 0000000..67161df
> --- /dev/null
> +++ b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> @@ -0,0 +1,348 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2018-2019 NXP
> + */
> +
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/of_device.h>

This could be of.h

Otherwise:
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Dong Aisheng
\
 
 \ /
  Last update: 2019-06-11 12:47    [W:0.114 / U:4.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site