lkml.org 
[lkml]   [2019]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lkdtm: no need to check return value of debugfs_create functions
On Tue, Jun 11, 2019 at 08:32:13PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
> drivers/misc/lkdtm/core.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/misc/lkdtm/core.c b/drivers/misc/lkdtm/core.c
> index 1972dad966f5..bae3b3763f3e 100644
> --- a/drivers/misc/lkdtm/core.c
> +++ b/drivers/misc/lkdtm/core.c
> @@ -429,22 +429,13 @@ static int __init lkdtm_module_init(void)
>
> /* Register debugfs interface */
> lkdtm_debugfs_root = debugfs_create_dir("provoke-crash", NULL);
> - if (!lkdtm_debugfs_root) {
> - pr_err("creating root dir failed\n");
> - return -ENODEV;
> - }
>
> /* Install debugfs trigger files. */
> for (i = 0; i < ARRAY_SIZE(crashpoints); i++) {
> struct crashpoint *cur = &crashpoints[i];
> - struct dentry *de;
>
> - de = debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root,
> - cur, &cur->fops);
> - if (de == NULL) {
> - pr_err("could not create crashpoint %s\n", cur->name);
> - goto out_err;
> - }
> + debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root, cur,
> + &cur->fops);
> }
>
> /* Install crashpoint if one was selected. */
> --
> 2.22.0
>

--
Kees Cook

\
 
 \ /
  Last update: 2019-06-11 22:45    [W:0.086 / U:4.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site