lkml.org 
[lkml]   [2019]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 00/11] net: stmmac: Selftests
On Thu, May 09, 2019 at 10:11:53AM +0000, Jose Abreu wrote:
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Thu, May 09, 2019 at 10:04:16
>
> > What means 1 for "Perfect Filter UC" ?
>
> Thank you for the testing :)
>
> 1 means that either the expected packet was not received or that the
> filter did not work.
>
> For GMAC there is the need to set the HPF bit in order for the test to
> pass. Do you have such bit in your HW ? It should be in EMAC_RX_FRM_FLT
> register.

The problem was missing IFF_UNICAST_FLT, so netcore put the device in promiscous when adding an unicast address.

Next step will be to enable Flow Control, but I will start a new thread for that.

>
> > I have added my patch below
>
> Do you want me to add your patch to the series ? If you send me with
> git-send-email I can apply it with your SoB.
>

I will do.
I will send the patch for IFF_UNICAST_FLT appart since it fixes a bug.

Regards

\
 
 \ /
  Last update: 2019-05-09 20:00    [W:0.063 / U:1.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site