lkml.org 
[lkml]   [2019]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 6/6] perf-probe: Add user memory access attribute support
On Thu, 9 May 2019 11:17:35 +0200
Ingo Molnar <mingo@kernel.org> wrote:

>
> * Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > --- a/tools/perf/util/probe-event.h
> > +++ b/tools/perf/util/probe-event.h
> > @@ -37,6 +37,7 @@ struct probe_trace_point {
> > struct probe_trace_arg_ref {
> > struct probe_trace_arg_ref *next; /* Next reference */
> > long offset; /* Offset value */
> > + bool user; /* User-memory access */
> > };
> >
> > /* kprobe-tracer and uprobe-tracer tracing argument */
> > @@ -82,6 +83,7 @@ struct perf_probe_arg {
> > char *var; /* Variable name */
> > char *type; /* Type name */
> > struct perf_probe_arg_field *field; /* Structure fields */
> > + bool user; /* User-memory */
>
> Why did the 'access' qualifier get dropped from the second comment?

Ah, it's my typo.

> Also, please name it and related parameters and local variables
> 'user_access' - in that case no comments are needed and it's all super
> clear. Only 'user' is ambiguous really.

Yes, that's a good idea! OK. I'll change it.

Thank you!

>
> Thanks,
>
> ngo


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2019-05-09 16:43    [W:0.035 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site