lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device
From
Date


On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> @@ -292,6 +309,12 @@ void dev_coredumpm(struct device *dev, struct module *owner,
> if (device_add(&devcd->devcd_dev))
> goto put_device;
>
> + for (i = 0; i < devcd->num_files; i++) {
> + if (device_create_bin_file(&devcd->devcd_dev,
> + &devcd->files[i].bin_attr))
> + /* nothing - some files will be missing */;

Is the conditional necessary if you aren't going to do anything?

> + }
> +
> if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
> "failing_device"))
> /* nothing - symlink will be missing */;

\
 
 \ /
  Last update: 2019-05-07 19:36    [W:0.069 / U:13.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site