lkml.org 
[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] perf/x86/intel: Support hardware TopDown metrics
On Tue, May 21, 2019 at 02:40:50PM -0700, kan.liang@linux.intel.com wrote:
> + x86_pmu.has_metric = x86_pmu.intel_cap.perf_metrics;

It makes sense to duplicate that state because?

> @@ -717,6 +729,8 @@ struct x86_pmu {
> struct extra_reg *extra_regs;
> unsigned int flags;
>
> + bool has_metric;
> +
> /*
> * Intel host/guest support (KVM)
> */

You forgot how I feel about _Bool in composite types _again_ ?

\
 
 \ /
  Last update: 2019-05-28 14:54    [W:0.175 / U:1.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site