lkml.org 
[lkml]   [2019]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 2/5] USB: use genalloc for USB HCs with local memory
Date

On 21.05.2019 18:27, Fredrik Noring wrote:
> Thanks Laurentiu!
>
>> --- a/include/linux/usb/hcd.h
>> +++ b/include/linux/usb/hcd.h
>> @@ -216,6 +216,9 @@ struct usb_hcd {
>> #define HC_IS_RUNNING(state) ((state) & __ACTIVE)
>> #define HC_IS_SUSPENDED(state) ((state) & __SUSPEND)
>>
>> + /* allocator for HCs having local memory */
>> + struct gen_pool *localmem_pool;
>> +
>
> I have tested patches 1, 2 and 5, and they seem to work. Nice!

Great! Thanks for testing. I'll add your Tested-By tags on the patches
you mentioned.

> May I suggest clarifying the NULL pointers? I think that may help someone
> debugging or maintaining this in the future. Something like this:

Sure, will include in v6.

---
Best Regards, Laurentiu
\
 
 \ /
  Last update: 2019-05-22 12:54    [W:0.102 / U:8.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site