lkml.org 
[lkml]   [2019]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.
From
Date
On Tue, 2019-05-21 at 17:54 +0000, Christophe Leroy wrote:
> Hi Joe & Andy
[]
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
[]
> > @@ -2356,7 +2356,7 @@ static struct talitos_alg_template driver_algs[] = {
> > .base = {
> > .cra_name = "authenc(hmac(sha1),cbc(aes))",
> > .cra_driver_name = "authenc-hmac-sha1-"
> > - "cbc-aes-talitos",
> > + "cbc-aes-talitos-hsna",
>
> checkpatch reports the following warning on the above:
>
> WARNING: quoted string split across lines
> #27: FILE: drivers/crypto/talitos.c:2359:
> .cra_driver_name = "authenc-hmac-sha1-"
> + "cbc-aes-talitos-hsna",
>
>
> But when I fixes the patch as follows, I get another warning:
>
> @@ -2355,8 +2355,7 @@ static struct talitos_alg_template driver_algs[] = {
> .alg.aead = {
> .base = {
> .cra_name = "authenc(hmac(sha1),cbc(aes))",
> - .cra_driver_name = "authenc-hmac-sha1-"
> - "cbc-aes-talitos",
> + .cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos-hsna",
> .cra_blocksize = AES_BLOCK_SIZE,
> .cra_flags = CRYPTO_ALG_ASYNC,
> },
>
>
>
> WARNING: line over 80 characters
> #28: FILE: drivers/crypto/talitos.c:2358:
> + .cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos-hsna",
>
>
> So, how should this be fixed ?

For at least now, by ignoring this checkpatch message.

It's a brainless script. You are not brainless.

\
 
 \ /
  Last update: 2019-05-21 20:11    [W:0.048 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site