lkml.org 
[lkml]   [2019]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling
Date
On 5/21/2019 12:18 PM, Anson Huang wrote:
> of_node_put() is called after of_match_node() successfully called,
> then in the following error handling, of_node_put() is called again
> which is unnecessary, this patch adjusts the location of of_node_put()
> to avoid such scenario.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

For both:

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>

I was thinking that maybe you could of_node_put as soon as you were done
with it but the model is read straight into soc_dev_attr so just freeing
everything at the end makes more sense.

\
 
 \ /
  Last update: 2019-05-21 13:04    [W:0.091 / U:4.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site