[lkml]   [2019]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v1 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of
correct definition makes device probing code more clear.

Signed-off-by: Oleksandr Suvorov <>

sound/soc/codecs/sgtl5000.c | 2 +-
sound/soc/codecs/sgtl5000.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git sound/soc/codecs/sgtl5000.c sound/soc/codecs/sgtl5000.c
index a6a4748c97f9..5e49523ee0b6 100644
--- sound/soc/codecs/sgtl5000.c
+++ sound/soc/codecs/sgtl5000.c
@@ -1296,7 +1296,7 @@ static int sgtl5000_probe(struct snd_soc_component *component)

/* enable small pop, introduce 400ms delay in turning off */
snd_soc_component_update_bits(component, SGTL5000_CHIP_REF_CTRL,
- SGTL5000_SMALL_POP, 1);

/* disable short cut detector */
snd_soc_component_write(component, SGTL5000_CHIP_SHORT_CTRL, 0);
diff --git sound/soc/codecs/sgtl5000.h sound/soc/codecs/sgtl5000.h
index 18cae08bbd3a..a4bf4bca95bf 100644
--- sound/soc/codecs/sgtl5000.h
+++ sound/soc/codecs/sgtl5000.h
@@ -273,7 +273,7 @@
#define SGTL5000_BIAS_CTRL_MASK 0x000e
#define SGTL5000_BIAS_CTRL_SHIFT 1
#define SGTL5000_BIAS_CTRL_WIDTH 3
-#define SGTL5000_SMALL_POP 1
+#define SGTL5000_SMALL_POP 0x0001



Ciklum refers to one or more of Ciklum Group Holdings LTD. and its
subsidiaries and affiliates each of which is a legally separate entity.
Ciklum LLC is a limited liability company registered in Ukraine under
EDRPOU code 31902643, with its registered address at 12 Amosova St., 03680,
Kyiv, Ukraine.

The contents of this e-mail (including any attachments)
are confidential and may be legally privileged. If you are not the intended
recipient of this e-mail, please notify the sender immediately and then
delete it (including any attachments) from all your systems. Any
unauthorised use, reproduction, distribution, disclosure and/or
modification of this message and/or its contents are strictly prohibited.
We cannot guarantee that this e-mail is secure or error-free. Ciklum cannot
be held liable for any loss or damage caused by software viruses or
resulting from any use of or reliance on this email by anyone, other than
the intended addressee to the extent agreed in a contract for the matter to
which this email relates (if any). Messages sent to and from Ciklum may be
monitored; by replying to this e-mail you give your consent to such
monitoring. Notice: we do not accept service by e-mail of court
proceedings, other processes or formal notices of any kind without specific
prior written agreement. This email does not constitute a binding offer or
acceptance for Ciklum unless so set forth in a separate document.

 \ /
  Last update: 2019-05-21 12:37    [W:0.134 / U:3.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site