lkml.org 
[lkml]   [2019]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c
On Tue, May 21, 2019 at 01:44:33PM -0700, Kees Cook wrote:
> This doesn't look safe to me: p->uni_pgdir[n] will still have a handle
> to the freed memory, won't it?
>
Thanks for your reply, Kees!
I think you are right. Maybe we should do this:
kfree(p1);
p->uni_pgdir[n] = NULL;
Is this correct?
> (And please direct these patches to Greg, as he's the current
> maintainer; I'm happy to stay CCed, of course.)
>
I will follow your suggestions, thanks!
Gen
> -Kees
>
> > memset(p2, 0xff, 64*sizeof(u16)); /* No glyphs for the characters (yet) */
> > }
> >
>
> --
> Kees Cook

\
 
 \ /
  Last update: 2019-05-22 03:51    [W:0.044 / U:18.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site