lkml.org 
[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings
From
Date

Hi Geert,

>
> On Mon, May 20, 2019 at 9:24 AM <masonccyang@mxic.com.tw> wrote:
> > > >>> - clocks: should contain 1 entries for the module's clock
> > > >>> - clock-names: should contain "rpc"
> > > >>
> > > >> I suspect we'd need the RPC/RPCD2 clocks mentioned as well
(not
> > sure
> > > > yet)...
> > > >
> > > > Need it ?
> > >
> > > You seem to call clk_get_rate() on the module clock, I doubt
that's
> > > correct topologically...
> >
> > I think it's correct but just like Geert mentioned that there is no
any
> > patch
> > in drivers/clk/renesas/r8a77995-cpg-mssr.c adding RPC-related clocks.
> >
> >
> > I patched dt-bindings/clock/r8a77995-cpg-mssr.h for some simple
testing
> >
> > -#define R8A77995_CLK_RPC 29
> > -#define R8A77995_CLK_RPCD2 30
> > +#define R8A77995_CLK_RPC 31
> > +#define R8A77995_CLK_RPCD2 32
>
> That change doesn't make sense to me...
>
> > by clk_prepare_enable() & clk_disable_unprepare() with CPG_MOD 917
> > on D3 draak board, it is working fine.
>
> ... and is not sufficient to allow the above two calls.
>
> Besides, making explicit clk_prepare_enable() calls bypasses Runtime PM
> and the automatic disabling of unused clocks, thus hiding bugs related
to
> Runtime PM. Which is probably why your driver doesn't work for
Sergei...
>

Got it, thanks for your explanation.

best regards,
Mason


CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

\
 
 \ /
  Last update: 2019-05-21 03:30    [W:0.090 / U:6.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site