Messages in this thread |  | | From | Vineet Gupta <> | Subject | Re: [PATCH 4/9] ARC: mm: do_page_fault refactor #3: tidyup vma access permission code | Date | Thu, 16 May 2019 17:37:51 +0000 |
| |
On 5/16/19 10:24 AM, Eugeniy Paltsev wrote: >> + unsigned int write = 0, exec = 0, mask; > Probably it's better to use 'bool' type for 'write' and 'exec' as we really use them as a boolean variables.
Right those are semantics, but the generated code for "bool" is not ideal - given it is inherently a "char" it is promoted first to an int with an additional EXTB which I really dislike. Guess it is more of a style thing.
-Vineet
|  |