Messages in this thread |  | | Subject | Re: [PATCH] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG | From | Jeff Kletsky <> | Date | Tue, 14 May 2019 15:08:06 -0700 |
| |
On 5/14/19 1:01 PM, Miquel Raynal wrote:
> Hi Schrempf, > > Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Tue, 14 May > 2019 16:11:28 +0000: > >> Hi Jeff, >> >> On 14.05.19 17:42, Jeff Kletsky wrote: >>> On 5/13/19 6:56 AM, Schrempf Frieder wrote: >>> >>>> Hi Jeff, >>>> >>>> [...] >>>> Maybe it would be better to split this patch into three parts: >>>> * Add support for two-byte device IDs >>>> * Add #define-s for three-byte addressing for read ops >>>> * Add support for GD5F1GQ4UFxxG >>>> >>>> Anyway the content looks good to me, so: >>>> >>>> Reviewed-by: Frieder Schrempf<frieder.schrempf@kontron.de> >>>> >>>> [...] >>> [...] > I agree with Frieder, if you don't mind, please split this commit in > three. > > Thanks, > Miquèl > Split and superseded by https://patchwork.ozlabs.org/project/linux-mtd/list/?series=107874
Jeff
|  |