lkml.org 
[lkml]   [2019]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] media: v4l2-subdev: Verify arguments of v4l2_subdev_call()
On Sat, May 11, 2019 at 12:10:30PM +0200, Janusz Krzysztofik wrote:
> +static int check_get_fmt(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_format *format)
> +{
> + return check_format(sd, format) ? :
> + sd->ops->pad->get_fmt(sd, cfg, format);

On naming --- when you're actually calling the function that does the job,
I'd call the wrapper e.g. call_something() instead. The current naming
suggests that only checks are being made.

--
Sakari Ailus
sakari.ailus@linux.intel.com

\
 
 \ /
  Last update: 2019-05-14 13:13    [W:0.049 / U:1.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site