lkml.org 
[lkml]   [2019]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] net: macb: fix error format in dev_err()
Date
On 14/05/2019 at 09:14, Luca Ceresoli wrote:
> External E-Mail
>
>
> Errors are negative numbers. Using %u shows them as very large positive
> numbers such as 4294967277 that don't make sense. Use the %d format
> instead, and get a much nicer -19.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Indeed!
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
> drivers/net/ethernet/cadence/macb_main.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index c049410bc888..bebd9b1aeb64 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3343,7 +3343,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
> if (!err)
> err = -ENODEV;
>
> - dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);
> return err;
> }
>
> @@ -3352,7 +3352,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
> if (!err)
> err = -ENODEV;
>
> - dev_err(&pdev->dev, "failed to get hclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);
> return err;
> }
>
> @@ -3370,31 +3370,31 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
>
> err = clk_prepare_enable(*pclk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
> return err;
> }
>
> err = clk_prepare_enable(*hclk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err);
> goto err_disable_pclk;
> }
>
> err = clk_prepare_enable(*tx_clk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err);
> goto err_disable_hclk;
> }
>
> err = clk_prepare_enable(*rx_clk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err);
> goto err_disable_txclk;
> }
>
> err = clk_prepare_enable(*tsu_clk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable tsu_clk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable tsu_clk (%d)\n", err);
> goto err_disable_rxclk;
> }
>
> @@ -3868,7 +3868,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk,
>
> err = clk_prepare_enable(*pclk);
> if (err) {
> - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
> + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
> return err;
> }
>
>


--
Nicolas Ferre
\
 
 \ /
  Last update: 2019-05-14 09:25    [W:0.051 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site