Messages in this thread |  | | Date | Mon, 13 May 2019 11:39:47 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCHv1 1/8] arm64: dts: Fix various entry-method properties to reflect documentation |
| |
On Fri 10 May 04:29 PDT 2019, Amit Kucheria wrote:
Subject indicates pluralism, but this fixes a specific platform (board?). I think you should update that.
> The idle-states binding documentation[1] mentions that the > 'entry-method' property is required on 64-bit platforms and must be set > to "psci". > > We fixed up all uses of the entry-method property in > commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to > reflect documentation"). But a new one has appeared. Fix it up. > > Cc: Sudeep Holla <sudeep.holla@arm.com>
The message looks good though, so with a new subject you have my:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards, Bjorn
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbcfa3bb..42e7822a0227 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -51,7 +51,7 @@ > * PSCI node is not added default, U-boot will add missing > * parts if it determines to use PSCI. > */ > - entry-method = "arm,psci"; > + entry-method = "psci"; > > CPU_PH20: cpu-ph20 { > compatible = "arm,idle-state"; > -- > 2.17.1 >
|  |