lkml.org 
[lkml]   [2019]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] module: Make srcu_struct ptr array as read-only post init
On Tue, Apr 09, 2019 at 10:38:20PM -0400, Steven Rostedt wrote:
> On Tue, 9 Apr 2019 21:14:18 -0400
> "Joel Fernandes (Google)" <joel@joelfernandes.org> wrote:
>
> > /*
> > - * Mark ro_after_init section with SHF_RO_AFTER_INIT so that
> > + * These are section names marked with SHF_RO_AFTER_INIT so that
>
> I'm curious to this much of a change. Wouldn't just making "section"
> plural also work?
>
> "Mark ro_after_init sections with ..."

Yes, I will change it to that and actually this comment change should go in
the previous patch so I'll squash it into that.

> Other than that, the two patches look fine to me.

Could I add your Reviewed-by in the respin?

thanks,

- Joel


> -- Steve
>
> > * layout_sections() can put it in the right place.
> > * Note: ro_after_init sections also have SHF_{WRITE,ALLOC} set.
> > */
> > @@ -3314,6 +3314,13 @@ static char *ro_after_init_sections[] = {

\
 
 \ /
  Last update: 2019-04-10 04:42    [W:0.050 / U:3.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site