lkml.org 
[lkml]   [2019]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] docs: Remove unnecessary reference link title
On Tue, Apr 09, 2019 at 03:20:30PM -0600, Jonathan Corbet wrote:
> On Tue, 9 Apr 2019 10:43:58 +1000
> "Tobin C. Harding" <tobin@kernel.org> wrote:
>
> > Labels that precede a heading use the heading as the link title.
> > Explicitly adding the link title is redundant and makes the reference
> > slightly less maintainable.
> >
> > Remove unnecessary reference link title.
>
> So I agree with the objective, but...
>
> > - As mentioned above in :ref:`VMA policies <vma_policy>` section,
> > + As mentioned above in :ref:`vma_policy` section,
>
> ...this one generates a warning that highlights a flaw in the reasoning
> here:
>
> Documentation/admin-guide/mm/numa_memory_policy.rst:144: WARNING:
> undefined label: vma-policy (if the link has no caption the label
> must precede a section header)
>
> Said label does not precede a section header, so it can't be used bare in
> this way.

That's weird, I did a clean build before and after applying the set and
diffed the stderr outputs, I wonder how I missed this.

> I'll apply the other three, but this one needs some repairs :)

thanks,
Tobin.

\
 
 \ /
  Last update: 2019-04-10 01:23    [W:0.127 / U:6.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site