lkml.org 
[lkml]   [2019]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] perf stat: Disable DIR_FORMAT feature for record
Em Tue, Apr 09, 2019 at 12:01:56PM +0200, Jiri Olsa escreveu:
> Arnaldo reported assertion in perf stat record:
>
> assertion failed at util/header.c:875

Thanks, applied and added:

Fixes: 258031c017c3 ("perf header: Add DIR_FORMAT feature to describe directory data")

- Arnaldo
>
> There's no support for this in perf state record
> command, disabling the feature.
>
> Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Link: http://lkml.kernel.org/n/tip-2uhyh815jfwikg5uhve8log6@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/builtin-stat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 7f9c4b7f5d69..a3c060878faa 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1322,6 +1322,7 @@ static void init_features(struct perf_session *session)
> for (feat = HEADER_FIRST_FEATURE; feat < HEADER_LAST_FEATURE; feat++)
> perf_header__set_feat(&session->header, feat);
>
> + perf_header__clear_feat(&session->header, HEADER_DIR_FORMAT);
> perf_header__clear_feat(&session->header, HEADER_BUILD_ID);
> perf_header__clear_feat(&session->header, HEADER_TRACING_DATA);
> perf_header__clear_feat(&session->header, HEADER_BRANCH_STACK);
> --
> 2.17.2

--

- Arnaldo

\
 
 \ /
  Last update: 2019-04-09 17:02    [W:0.072 / U:25.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site