lkml.org 
[lkml]   [2019]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] arch: arm64: process: Unlock console after SMP stopped
On Tue, Apr 09, 2019 at 11:17:14PM +0900, Jinyoung Park wrote:
> If the console lock is held by other CPU running while the system is
> restarting or shutting down, the Kernel messages in the printk log buffer
> can not be printed out to the console drivers. The Kernel messages can be
> lost or messed up.
> This change calls console_unlock after SMP stopped to flush the kernel
> messages in the printk log buffer to the console drivers.
>
> Signed-off-by: Jinyoung Park <jinyoungp@nvidia.com>
> ---
> arch/arm64/kernel/process.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index 3767fb21a5b8..d629a75c7602 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -49,6 +49,7 @@
> #include <trace/events/power.h>
> #include <linux/percpu.h>
> #include <linux/thread_info.h>
> +#include <linux/console.h>
>
> #include <asm/alternative.h>
> #include <asm/arch_gicv3.h>
> @@ -164,6 +165,7 @@ void machine_halt(void)
> {
> local_irq_disable();
> smp_send_stop();
> + console_unlock();
> while (1);
> }
>
> @@ -177,6 +179,7 @@ void machine_power_off(void)
> {
> local_irq_disable();
> smp_send_stop();
> + console_unlock();
> if (pm_power_off)
> pm_power_off();
> }
> @@ -195,6 +198,7 @@ void machine_restart(char *cmd)
> /* Disable interrupts first */
> local_irq_disable();
> smp_send_stop();
> + console_unlock();

Hmm, why don't other architectures seem to do this?

Will

\
 
 \ /
  Last update: 2019-04-09 16:19    [W:0.103 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site