lkml.org 
[lkml]   [2019]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver
On Mon, Apr 8, 2019 at 9:43 PM Rajat Jain <rajatja@google.com> wrote:
> On Mon, Apr 8, 2019 at 9:51 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain <rajatja@google.com> wrote:

> > > + switch (boot_cpu_data.x86_model) {
> >
> > I didn't get why this should be boot CPU?
> > Otherwise, leave the structure and leave the x86_match_cpu() call.
>
> I didn't quite understand the concern. The x86_match_cpu() also uses
> the same boot_cpu_data that I've used, am I missing something?

It's a detail of implementation, and instead of continue using nice
helpers, you open coded the similar.
Why?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-04-08 20:45    [W:0.081 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site