lkml.org 
[lkml]   [2019]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 05/14] x86/hpet: Relocate flag definitions to a header file
On Tue, Mar 26, 2019 at 10:11:16PM +0100, Thomas Gleixner wrote:
> On Wed, 27 Feb 2019, Ricardo Neri wrote:
>
> > Users of HPET timers (such as the hardlockup detector) need the definitions
> > of these flags to interpret the configuration of a timer as passed by
> > platform code.
>
> Which platform code?

Sorry, it is not platform code. Shall I call it the HPET-enabling code?
>
> > +#define HPET_DEV_USED_BIT 2
> > +#define HPET_DEV_USED (1 << HPET_DEV_USED_BIT)
> > +#define HPET_DEV_VALID 0x8
> > +#define HPET_DEV_FSB_CAP 0x1000
> > +#define HPET_DEV_PERI_CAP 0x2000
>
> I'm not seing why you would need any of those in the watchdog code.
>
> The only function related to the watchdog which needs these is
> hpet_hardlockup_detector_assign_timer() and that is located in hpet.c
> itself.

Yes, I see now that it is not needed. This patch can be removed.

Thanks and BR,
Ricardo

\
 
 \ /
  Last update: 2019-04-09 04:06    [W:0.079 / U:1.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site