[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tcp: remove redundant check on tskb
On Thu, Apr 4, 2019 at 7:46 AM Colin King <> wrote:
> From: Colin Ian King <>
> The non-null check on tskb is always false because it is in an else
> path of a check on tskb and hence tskb is null in this code block.
> This is check is therefore redundant and can be removed as well
> as the label coalesc.

> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <>

SGTM, thanks.

Signed-off-by: Eric Dumazet <>

 \ /
  Last update: 2019-04-05 09:49    [W:0.121 / U:3.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site