lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT
On Wed, Apr 03, 2019 at 05:45:02PM -0300, Lucas Oshiro wrote:
> #define AD7746_VTSETUP_VTMD_INT_TEMP (0 << 5)
> -#define AD7746_VTSETUP_VTMD_EXT_TEMP (1 << 5)
> +#define AD7746_VTSETUP_VTMD_EXT_TEMP BIT(5)

No, the original is more readable. Otherwise you can't see that it's
part of a set.

Just ignore checkpatch when it gives nonsense advice.

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-04-04 11:27    [W:0.047 / U:11.996 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site