lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH 1/3] soundwire: fix style issues
From
Date
Thanks for the review Joe,

@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave
*slave)

>> mutex_unlock(&slave->bus->bus_lock);
>> if (dev_num < 0) {
>> dev_err(slave->bus->dev, "Get dev_num failed: %d",
>> - dev_num);
>> + dev_num);
> You could also add the missing terminating '\n' to these formats like:
>
> dev_err(slave->bus->dev, "Get dev_num failed: %d\n",
>
Yes indeed, I just fixed that tools reported, but that is a miss. Will
fix with a v2 (hopefully with other comments).

-Pierre

\
 
 \ /
  Last update: 2019-04-04 21:37    [W:0.031 / U:2.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site