lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] soundwire: fix style issues
From
Date
On Thu, 2019-04-04 at 13:22 -0500, Pierre-Louis Bossart wrote:
> Visual inspections confirmed by checkpatch.pl --strict expose a number
> of style issues, specifically parameter alignment is inconsistent as
> if different contributors used different styles. Before we restart
> support for SoundWire with Sound Open Firmware on Intel platforms,
> let's clean all this.
>
> Fix Kconfig help, spelling, SPDX format, alignment, spurious
> parentheses, bool comparisons to true/false, macro argument
> protection.
>
> No new functionality added.

[]

> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
[]
> @@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave)
> mutex_unlock(&slave->bus->bus_lock);
> if (dev_num < 0) {
> dev_err(slave->bus->dev, "Get dev_num failed: %d",
> - dev_num);
> + dev_num);

You could also add the missing terminating '\n' to these formats like:

dev_err(slave->bus->dev, "Get dev_num failed: %d\n",

> return dev_num;
> }
> } else {
> dev_info(slave->bus->dev,
> - "Slave already registered dev_num:%d",
> - slave->dev_num);
> + "Slave already registered dev_num:%d",
> + slave->dev_num);

etc...



\
 
 \ /
  Last update: 2019-04-04 21:29    [W:0.065 / U:3.512 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site