lkml.org 
[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support
Hi!

> > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in
> > > > the first place. But it happened. We want all backlights for the
> > > > system keyboard to use common name, and "chromeos" is not really
> > > > suitable for that. "platform" is.
> > >
> > > Pavel, who exactly wants this and why? Looking at today's -next I see:
> > >
> > > dtor@dtor-ws:~/kernel/linux-next ((next-20190404))$ git grep
> > > "::kbd_backlight" | wc -l
> > > 18
> > > dtor@dtor-ws:~/kernel/linux-next ((next-20190404))$ git grep
> > > "platform::kbd_backlight" | wc -l
> > > 0
> > >
> > > so there isn't a single instance of "platform::kbd_backlight" and we
> > > definitely not changing existing names.
> >
> > Yeah, we made mistakes in the past. We _don't_ want userspace to have
> > ever growing list of names for userspace to follow.
> >
> > Backlight of internal keyboard is pretty common concept and there
> > should be one name for it.
>
> It is the *function* that is interesting to userspace, not full name,
> and we have proper standardization there.

Well, if full name is not interesting, as you argue, why do we have
this discussion?
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-04-04 21:24    [W:0.072 / U:3.804 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site