[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [v3 PATCH 5/6] usb: roles: add USB Type-B GPIO connector driver
On Wed, Apr 3, 2019 at 9:09 AM Chunfeng Yun <> wrote:

> Due to the requirement of usb-connector.txt binding, the old way
> using extcon to support USB Dual-Role switch is now deprecated
> when use Type-B connector.
> This patch introduces a driver of Type-B connector which typically
> uses an input GPIO to detect USB ID pin, and try to replace the
> function provided by extcon-usb-gpio driver
> Signed-off-by: Chunfeng Yun <>
> +#include <linux/gpio.h>

If you need this include in a consumer, something is wrong. Just delete it,

> + info->id_gpiod = devm_gpiod_get_from_of_node(
> + dev, child, "id-gpios", 0, GPIOD_IN, "idpin");

This is OK if the child does not have any Linux device (struct platform_device
etc) created from it. Is this the case?

Linus Walleij

 \ /
  Last update: 2019-04-04 18:36    [W:0.099 / U:3.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site