[lkml]   [2019]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drm/cirrus: rewrite and modernize driver.

Den 04.04.2019 12.27, skrev Gerd Hoffmann:
> Hi,
>>> tinydrm_xrgb8888_to_*
>>> imo these could be put into some drm_format_helpers.c to be shared.
>> I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got
>> there yet.
>> Gerd, if you end up using some of those functions, feel free to move
>> just those you need and I can do the rest later. But if you have time to
>> spare I wouldn't mind getting all of them moved ;-)
> For now I just promoted cirrus to be a tinydrm driver ;)
> Noticed that those helpers (including tinydrm_memcpy for the
> non-converting case) apply clipping on the source but not on
> the destination. So, for fullscreen updates that works ok,
> but for updating sub-rectangles it doesn't ...

Ah yes, these MIPI type controllers support setting the destination
window in controller RAM for the incoming buffer so there has been no
need for clipping on the destination buffer.

> So I guess I have to add a dest_clip bool parameter when moving them.
> /me looks for a good place. drm_fb_helpers.c I think.
> cheers,
> Gerd

 \ /
  Last update: 2019-04-04 13:45    [W:0.057 / U:4.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site