lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ftpm: firmware TPM running in TEE
On Tue, Apr 02, 2019 at 01:56:43PM -0700, Stephen Hemminger wrote:
> On Tue, 2 Apr 2019 12:33:16 -0700
> "Sasha Levin" <sashal@kernel.org> wrote:
>
> > +/*
> > + * ftpm_tee_tpm_op_recv retrieve fTPM response.
> > + * @param: chip, the tpm_chip description as specified in
> > driver/char/tpm/tpm.h.
> > + * @param: buf, the buffer to store data.
> > + * @param: count, the number of bytes to read.
> > + * @return: In case of success the number of bytes received.
> > + * In other case, a < 0 value describing the issue.
> > + */
>
> You are using a docbook style comment but it doesn't start with
> docbook prefix.
>
> /**
> * ftpm_tee_tpm_op_recv retrieve fTPM response.
> *
> * @param: chip, the tpm_chip description as specified in driver/char/tpm/tpm.h.
> * @param: buf, the buffer to store data.
> * @param: count, the number of bytes to read.
> * @return: In case of success the number of bytes received.
> * In other case, a < 0 value describing the issue.
> */

This is different commenting style that we use on anything else
under drivers/char/tpm.

/Jarkko

\
 
 \ /
  Last update: 2019-04-03 20:20    [W:0.118 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site