lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] drm/tegra: fix possible object reference leak
    Date
    The call to  of_get_child_by_name returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./drivers/gpu/drm/tegra/rgb.c:225:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 223, but without a corresponding object release within this function.
    ./drivers/gpu/drm/tegra/rgb.c:229:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 223, but without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Thierry Reding <thierry.reding@gmail.com>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: Jonathan Hunter <jonathanh@nvidia.com>
    Cc: dri-devel@lists.freedesktop.org
    Cc: linux-tegra@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/gpu/drm/tegra/output.c | 2 ++
    drivers/gpu/drm/tegra/rgb.c | 8 ++++++--
    2 files changed, 8 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c
    index 9c2b9da..78553d7 100644
    --- a/drivers/gpu/drm/tegra/output.c
    +++ b/drivers/gpu/drm/tegra/output.c
    @@ -193,6 +193,8 @@ void tegra_output_remove(struct tegra_output *output)

    if (output->ddc)
    put_device(&output->ddc->dev);
    + if (output->of_node)
    + of_node_put(output->of_node);
    }

    int tegra_output_init(struct drm_device *drm, struct tegra_output *output)
    diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c
    index 28a78d3..ad683a2 100644
    --- a/drivers/gpu/drm/tegra/rgb.c
    +++ b/drivers/gpu/drm/tegra/rgb.c
    @@ -221,12 +221,16 @@ int tegra_dc_rgb_probe(struct tegra_dc *dc)
    int err;

    np = of_get_child_by_name(dc->dev->of_node, "rgb");
    - if (!np || !of_device_is_available(np))
    + if (!np || !of_device_is_available(np)) {
    + of_node_put(np);
    return -ENODEV;
    + }

    rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL);
    - if (!rgb)
    + if (!rgb) {
    + of_node_put(np);
    return -ENOMEM;
    + }

    rgb->output.dev = dc->dev;
    rgb->output.of_node = np;
    --
    2.9.5
    \
     
     \ /
      Last update: 2019-04-03 18:04    [W:4.152 / U:4.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site