lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 7/7] irqchip/irq-mvebu-sei: Use devm_platform_ioremap_resource()
From
Date
On 04/04/2019 08:20, Mukesh Ojha wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> ---
> drivers/irqchip/irq-mvebu-sei.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-sei.c
> index 18832cc..0a09dcc 100644
> --- a/drivers/irqchip/irq-mvebu-sei.c
> +++ b/drivers/irqchip/irq-mvebu-sei.c
> @@ -382,8 +382,7 @@ static int mvebu_sei_probe(struct platform_device *pdev)
> mutex_init(&sei->cp_msi_lock);
> raw_spin_lock_init(&sei->mask_lock);
>
> - sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - sei->base = devm_ioremap_resource(sei->dev, sei->res);
> + sei->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(sei->base)) {
> dev_err(sei->dev, "Failed to remap SEI resource\n");
> return PTR_ERR(sei->base);
>

Again, what about sei->res?

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2019-04-29 10:20    [W:0.078 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site