[lkml]   [2019]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH AUTOSEL 4.19 03/53] ASoC: ab8500: Mark expected switch fall-through
From: "Gustavo A. R. Silva" <>

[ Upstream commit 102cefc8e879b707be0024fdc7bce1deeb359a5f ]

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

In file included from sound/soc/codecs/ab8500-codec.c:24:
sound/soc/codecs/ab8500-codec.c: In function ‘ab8500_codec_set_dai_fmt’:
./include/linux/device.h:1485:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
sound/soc/codecs/ab8500-codec.c:2129:3: note: in expansion of macro ‘dev_err’
sound/soc/codecs/ab8500-codec.c:2132:2: note: here

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable

Signed-off-by: Gustavo A. R. Silva <>
Signed-off-by: Mark Brown <>
Signed-off-by: Sasha Levin <>
sound/soc/codecs/ab8500-codec.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 03bbbcd3b6c1..87616b126018 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2129,6 +2129,7 @@ static int ab8500_codec_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
"%s: ERROR: The device is either a master or a slave.\n",
+ /* fall through */
"%s: ERROR: Unsupporter master mask 0x%x\n",
 \ /
  Last update: 2019-04-27 03:41    [W:0.171 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site