lkml.org 
[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v12 07/31] mm: make pte_unmap_same compatible with SPF
On Tue, Apr 16, 2019 at 03:44:58PM +0200, Laurent Dufour wrote:
> +static inline vm_fault_t pte_unmap_same(struct vm_fault *vmf)
> {
> - int same = 1;
> + int ret = 0;

Surely 'ret' should be of type vm_fault_t?

> + ret = VM_FAULT_RETRY;

... this should have thrown a sparse warning?

\
 
 \ /
  Last update: 2019-04-23 17:44    [W:0.602 / U:24.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site