[lkml]   [2019]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD
On Mon, Apr 01, 2019 at 02:55:19PM -0600, Fletcher Woodruff wrote:
> The rt5677 driver is using the wrong property names to read from ACPI.
> Update the property names to match those from _DSD, so that the correct
> GPIO pin numbers are read and that plug-detection works.

> With this patch, plugging and unplugging the headphone jack switches
> between headphones and speakers automatically.

What makes you say that these properties are wrong? Are you sure that
this isn't just some other systems using different ACPI properties given
the poor standardization for ACPI? Your new ones look like they're DT
properties pulled into ACPI while the existing ones look more idiomatic
for ACPI. It'd be fine to add your new DT style properties but this
might break existing systems.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-04-02 07:07    [W:0.125 / U:5.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site