lkml.org 
[lkml]   [2019]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 7/8] i2c: iproc: add NIC I2C support

> +#define IDM_CTRL_DIRECT_OFFSET 0x00

And this IDM thing is also never used outside of the I2C context? In
other words, it also doesn't need a seperate DT node?


> + /* indicates no slave mode support */
> + bool no_slave;

I would suggest to not use a flag, but to nullify the {un}reg_slave
callbacks in probe depending on the type. That will also tell the
i2c-core that slave functionality is not supported. And you can use if
(!algo->reg_slave) as a flag, too.

> + iproc_i2c->type =
> + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev);

No need to cast a void*.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-04-02 12:28    [W:0.172 / U:2.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site