lkml.org 
[lkml]   [2019]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 7/8] i2c: iproc: add NIC I2C support
From
Date


On 4/2/2019 10:57 AM, Ray Jui wrote:
>
>
> On 4/2/2019 3:27 AM, Wolfram Sang wrote:

[...]

>>> + iproc_i2c->type =
>>> + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev);
>>
>> No need to cast a void*.
>>

In fact, we do need to type cast here since 'iproc_i2c->type' is NOT a
pointer:

drivers/i2c/busses/i2c-bcm-iproc.c:870:18: error: incompatible types
when assigning to type ‘enum bcm_iproc_i2c_type’ from type ‘const void *’
iproc_i2c->type = of_device_get_match_data(&pdev->dev);
^
>
> Yes will fix.
>
> Thanks,
>
> Ray
>

\
 
 \ /
  Last update: 2019-04-03 03:12    [W:0.062 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site