lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels
On Tue, Apr 16, 2019 at 12:02:26PM +0200, Ingo Molnar wrote:
>
> * Borislav Petkov <bp@alien8.de> wrote:
>
> > I'll queue the below in the next days if there are no more complaints:
>
> Just a minor style nit, this was inherited from existing code:
>
> > + efi_config_table_64_t *tbl = (efi_config_table_64_t *) config_tables + i;
> > + efi_config_table_32_t *tbl = (efi_config_table_32_t *) config_tables + i;
>
> You might want to update that to the canonical form of:
>
> > + efi_config_table_64_t *tbl = (efi_config_table_64_t *)config_tables + i;
> > + efi_config_table_32_t *tbl = (efi_config_table_32_t *)config_tables + i;
>
> Looks good otherwise.

Fixed, thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2019-04-16 12:32    [W:0.105 / U:6.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site