lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller
On Tue, Apr 16, 2019 at 5:07 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:>
> By the grey theory it would be better to split it into two separate
> drivers. But obviously, they need need a common part (a third piece).

Well yes, we could treat it as an mfd device, with a common register accessor,
which registers anybus-s host and adc drivers, all selectable via
Kconfig / defconfig... But that's a lot of extra code just to handle one single
bit in a register, which is a boolean input.

Can be done but is it worth it?

>
> Does it ever make sense to only use one of two functionalities ?

That depends on what the userspace app wants to do.
Our userspace app always attempts to monitor the CAN readout.

>
> Does this power read-out involve some CAN traffic, or is it just
> fetching from some card that just happens to be some CAN interface ?
> (IOW: is cansocket needed for that ?)
>

It is purely a boolean input. The boolean output of a voltage monitor chip.
When our hardware is assembled, the voltage monitor input is connected
to a signal which indicates the CAN status. In theory, it could be connected
to the factory's light switch. It would then read out the status of the factory
floor lights. It has no CAN functionality whatsoever.

\
 
 \ /
  Last update: 2019-04-16 23:24    [W:0.073 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site