lkml.org 
[lkml]   [2019]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] doc: kselftest: Fix KBUILD_OUTPUT usage instructions
On Tue, 16 Apr 2019 09:50:16 -0600
shuah <shuah@kernel.org> wrote:

> >> +Build and run from KBUILD_OUTPUT directory (make KBUILD_OUTPUT=)::
> >>
> >> - $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
> >> + $ export KBUILD_OUTPUT=/tmp/kselftest; make kselftest
> >
> > Is there a particular reason why this variable needs to be set in the
> > environment rather than just in make? More importantly, though, I don't
> > think this would work if you run it from the KBUILD_OUTPUT directory. What
> > you're really doing is running with a separate output directory, right?
> >
>
> That is correct. I am matching the instructions in the main Makefile:
>
> # kbuild supports saving output files in a separate directory.

So my concern was right, then: this is not a way to "run from the
KBUILD_OUTPUT" directory; that seems certain to confuse people. I'll
apply the patch so that the commands are right, but that could maybe use
some tweaking.

Thanks,

jon

\
 
 \ /
  Last update: 2019-04-16 21:59    [W:0.106 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site