lkml.org 
[lkml]   [2019]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt
From
Date
Hi Enrico,

On 12.04.19 15:15, Enrico Weigelt, metux IT consult wrote:
> On 11.04.19 15:30, Stefan Wahren wrote:
>> This adds RPM support to the pwm-fan driver in order to use with
>> fancontrol/pwmconfig. This feature is intended for fans with a tachometer
>> output signal, which generate a defined number of pulses per revolution.
> Wouldn't it be better to have a CONFIG_* flag for keeping the kernel
> image size smaller when this feature isn't needed ?

i compared the kernel module size in linux-next for ARM without and with
this patch:
without patch: 12088 bytes
with patch: 14292 bytes

I don't think it is worth the trouble.

Stefan

>
>
> --mtx
>

\
 
 \ /
  Last update: 2019-04-12 15:36    [W:0.069 / U:37.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site